Skip to content

Add the ability to consider reactions - #1086

Open
gorzelinski wants to merge 18 commits into
actions:mainfrom
gorzelinski:add-reaction-updates
Open

Add the ability to consider reactions#1086
gorzelinski wants to merge 18 commits into
actions:mainfrom
gorzelinski:add-reaction-updates

Conversation

@gorzelinski

Copy link
Copy Markdown

Description:
As mentioned in #861 (comment), in some projects it’s useful to track reactions as activity. This PR adds such an option (disabled by default). We tested it on our primary and supporting repositories, and it works as expected.

Related issue:
#861

Check list:

  • Mark if documentation changes are required.
  • Mark if tests were added or updated to cover the changes.

@gorzelinski
gorzelinski requested a review from a team as a code owner September 4, 2023 08:47
@dsame dsame self-assigned this Sep 6, 2023
@dsame

dsame commented Sep 6, 2023

Copy link
Copy Markdown
Contributor

Hello @gorzelinski , we started to review the PR, but can you please meanwhile fix the failed checks of the PR?

@gorzelinski

Copy link
Copy Markdown
Author

Hey @dsame, sure, I'll look into it ASAP.

@gorzelinski gorzelinski closed this Sep 6, 2023
@gorzelinski gorzelinski reopened this Sep 6, 2023
@dsame dsame linked an issue Sep 13, 2023 that may be closed by this pull request
@dsame dsame added the feature request New feature or request to improve the current logic label Sep 13, 2023
@gorzelinski

Copy link
Copy Markdown
Author

Should I do something more? As I see, the checks are passing now.

@nitrocode

Copy link
Copy Markdown

cc: @gorzelinski thanks for contributing this!

cc: @marko-zivic-93 @MaksimZhukov @dusan-trickovic friendly ping. Please review when you folks get a chance. This will help a lot more issues stay active that are being reacted to. Thank you for maintaining this action for us!

@gorzelinski

Copy link
Copy Markdown
Author

Hey @nitrocode, do we need additional reviews? Sorry for bothering you, but avoiding merge conflicts would be great.

@nitrocode

Copy link
Copy Markdown

Hi @gorzelinski , I do not manage this repo. I was just trying to get this reviewed so we can eventually get it merged.

I can see from past merges that each merge seemed to require at least 2 approvals before merging

https://github.com/actions/stale/pulls?q=is%3Apr+is%3Amerged+-author%3Aapp%2Fdependabot+

@gorzelinski

Copy link
Copy Markdown
Author

@nitrocode Oh, I didn't know. Thanks for the info anyway.
So maybe I'll forward it to @dsame.

Comment thread README.md

If set to `false`, any reaction to an issue will be considered an update.

Default value: unset

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I personally would have this set by default

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature request New feature or request to improve the current logic

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Issues should be kept active if reactions (ie upvotes) or backlinks

4 participants